slavkap commented on a change in pull request #5801:
URL: https://github.com/apache/cloudstack/pull/5801#discussion_r774483982



##########
File path: 
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/KVMStorageProcessor.java
##########
@@ -1463,7 +1463,7 @@ public Answer createVolume(final CreateObjectCommand cmd) 
{
             primaryPool = 
storagePoolMgr.getStoragePool(primaryStore.getPoolType(), 
primaryStore.getUuid());
             disksize = volume.getSize();
             PhysicalDiskFormat format;
-            if (volume.getFormat() == null) {
+            if (volume.getFormat() == null || 
StoragePoolType.RBD.equals(primaryStore.getPoolType())) {

Review comment:
       Hi @sureshanaparti, thank you for the review! I wondered where to set 
the correct format. When we attach an allocated  Ceph volume, we set RAW format 
here. That's why I decided to do this in one place and in my case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to