GabrielBrascher commented on pull request #5826: URL: https://github.com/apache/cloudstack/pull/5826#issuecomment-1006425893
That code is 10 years old, in "another era" where there was not much IPv6 support. Nowadays, most repositories serve both IPv4 and IPv6. @DaanHoogland It is important to note that it could fail to register templates/ISOs from repositories with IPv6 addresses only, in the scenarios where SSVMs do not have an IPv6 address (might be the majority of cases, I don't know who configures or not SystemVMs with IPv6). With that said, I still prefer to have an exception such as `"could not reach the host"`, instead of getting CloudStack blocking right away in case of IPv6 assuming that it is not supported. To put some context. The reported issue happened in a test-env where Java was configured to prefer IPv6 over IPv4 `-Djava.net.preferIPv6Addresses=true`. By default, we don't have Java choosing IPv6 over IPv4. We should add `preferIPv6Addresses` in the future. The repositories that I've tested always had IPv6 & IPv4, thus it worked fine for any network setup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
