shwstppr commented on a change in pull request #5854:
URL: https://github.com/apache/cloudstack/pull/5854#discussion_r783873732
##########
File path: api/src/main/java/org/apache/cloudstack/acl/APIChecker.java
##########
@@ -27,4 +28,6 @@
// If false, apiChecker is unable to handle the operation or not
implemented
// On exception, checkAccess failed don't allow
boolean checkAccess(User user, String apiCommandName) throws
PermissionDeniedException;
+
+ boolean checkAccess(Account account, User user, String apiCommandName,
Role role) throws PermissionDeniedException;
Review comment:
@weizhouapache made some changes to query only enabled APICheckers for
checkAccess.
Also, realized my earlier tests were a bit skewed as I should be comparing
vanilla 4.16 branch with this PR build instead of only trim parameter usage of
the API. Will test and report them
cc @rohityadavcloud
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
