DaanHoogland commented on a change in pull request #5863:
URL: https://github.com/apache/cloudstack/pull/5863#discussion_r785789564
##########
File path: engine/schema/pom.xml
##########
@@ -181,7 +182,8 @@
</goals>
<configuration>
<checkSignature>true</checkSignature>
-
<url>https://download.cloudstack.org/systemvm/${cs.version}/systemvmtemplate-${cs.version}.${patch.version}-kvm.qcow2.bz2</url>
+<!--
<url>https://download.cloudstack.org/systemvm/${cs.version}/systemvmtemplate-${cs.version}.${patch.version}-kvm.qcow2.bz2</url>-->
+
<url>http://10.0.3.122/systemvmtemplate/custom/cks-debian/${cs.version}/1/systemvmtemplate-${cs.version}.${patch.version}-kvm.qcow2.bz2</url>
Review comment:
don't merge this
##########
File path: engine/schema/pom.xml
##########
@@ -122,7 +122,8 @@
<goal>wget</goal>
</goals>
<configuration>
-
<url>https://download.cloudstack.org/systemvm/${cs.version}/md5sum.txt</url>
+<!--
<url>https://download.cloudstack.org/systemvm/${cs.version}/md5sum.txt</url>-->
+
<url>http://10.0.3.122/systemvmtemplate/custom/cks-debian/${cs.version}/1/md5sum.txt</url>
Review comment:
I,m pretty sure we don't want to merge this
##########
File path: engine/schema/pom.xml
##########
@@ -205,7 +208,8 @@
</goals>
<configuration>
<checkSignature>true</checkSignature>
-
<url>https://download.cloudstack.org/systemvm/${cs.version}/systemvmtemplate-${cs.version}.${patch.version}-xen.vhd.bz2</url>
+<!--
<url>https://download.cloudstack.org/systemvm/${cs.version}/systemvmtemplate-${cs.version}.${patch.version}-xen.vhd.bz2</url>-->
+
<url>http://10.0.3.122/systemvmtemplate/custom/cks-debian/${cs.version}/1/systemvmtemplate-${cs.version}.${patch.version}-xen.vhd.bz2</url>
Review comment:
remove
##########
File path:
engine/schema/src/main/java/com/cloud/upgrade/SystemVmTemplateRegistration.java
##########
@@ -690,7 +679,7 @@ public void
registerTemplate(Pair<Hypervisor.HypervisorType, String> hypervisorA
}
}
- public static void parseMetadataFile() {
+ public static String parseMetadataFile() {
Review comment:
can you add a javadoc to describe the return, please?
##########
File path: engine/schema/pom.xml
##########
@@ -193,7 +195,8 @@
</goals>
<configuration>
<checkSignature>true</checkSignature>
-
<url>https://download.cloudstack.org/systemvm/${cs.version}/systemvmtemplate-${cs.version}.${patch.version}-vmware.ova</url>
+<!--
<url>https://download.cloudstack.org/systemvm/${cs.version}/systemvmtemplate-${cs.version}.${patch.version}-vmware.ova</url>-->
+
<url>http://10.0.3.122/systemvmtemplate/custom/cks-debian/${cs.version}/1/systemvmtemplate-${cs.version}.${patch.version}-vmware.ova</url>
Review comment:
please remove
##########
File path: utils/src/main/java/com/cloud/utils/EncryptionUtil.java
##########
@@ -70,4 +74,14 @@ public static String generateSignature(String data, String
key) {
throw new CloudRuntimeException("unable to generate signature", e);
}
}
+
+ public static String calculateChecksum(File file) {
Review comment:
doesn't this belong in the DigestUtils?
It makes no use of code or data defined here and is not used here. I'm not
sure what the arguments for putting it here are, but one against: it adds a
dependency from here to DigestUtils, which is not needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
