sureshanaparti commented on a change in pull request #5892:
URL: https://github.com/apache/cloudstack/pull/5892#discussion_r792657296
##########
File path:
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
##########
@@ -1899,13 +1900,25 @@ protected void fillHostInfo(final Connection conn,
final StartupRoutingCommand c
}
}
+ protected void syncPlatformAndCoresPerSocketSettings(String
coresPerSocket, Map<String, String> platform) {
+ if (org.apache.commons.lang3.StringUtils.isBlank(coresPerSocket) ||
MapUtils.isEmpty(platform)) {
Review comment:
add to `platform`, even if it doesn't have any elements ?
```suggestion
if (org.apache.commons.lang3.StringUtils.isBlank(coresPerSocket) ||
platform = null) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
