DaanHoogland commented on pull request #5920:
URL: https://github.com/apache/cloudstack/pull/5920#issuecomment-1026898374


   your code looks good @weizhouapache can you think of the testing we need to 
do for this?
   The obvious is just creating a network as normal user with a network 
offering without source-nat. But other than that?
   Or do we just let it go with the generic regression testing on the RC?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to