shwstppr commented on a change in pull request #5954:
URL: https://github.com/apache/cloudstack/pull/5954#discussion_r800324779
##########
File path: server/src/main/java/com/cloud/storage/StorageManagerImpl.java
##########
@@ -2808,30 +2808,32 @@ public void doInTransactionWithoutResult(final
TransactionStatus status) {
Pair<String, Long> storeUrlAndId = new Pair<>(url,
store.getId());
for (HypervisorType hypervisorType : hypSet) {
try {
- String templateName =
getValidTemplateName(zoneId, hypervisorType);
- Pair<Hypervisor.HypervisorType, String>
hypervisorAndTemplateName =
- new Pair<>(hypervisorType,
templateName);
- Long templateId =
systemVmTemplateRegistration.getRegisteredTemplateId(hypervisorAndTemplateName);
- VMTemplateVO vmTemplateVO = null;
- TemplateDataStoreVO templateVO = null;
- if (templateId != null) {
- vmTemplateVO =
_templateDao.findById(templateId);
- templateVO =
_templateStoreDao.findByTemplate(templateId, DataStoreRole.Image);
- if (templateVO != null) {
- try {
- if
(SystemVmTemplateRegistration.validateIfSeeded(url,
templateVO.getInstallPath())) {
- continue;
+ if (HypervisorType.Simulator !=
hypervisorType) {
Review comment:
@Pearl1594 nit-picking but can we use `continue` instead of wrapping
everything in a new if statement
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
