[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library

[GitBox]

rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1031234151


   @utchoang some initial notes:
   - there's a lot of css issues between this PR and the main branch, for ex. 
issue of margins, colours (on hover)
   - settings panel visible - what's the use of that? (it doesn't really save 
any setting, either a json downloaded or in backend)
   - open UI from main and during development/testing compare/fix issues from 
this PR
   - Can you also run a smoketest or full test plan on the UI 
https://github.com/apache/cloudstack-primate/blob/master/.github/ISSUE_TEMPLATE/test_full_plan.md
 and report your findings?
    
   Here are screenshots for comparing UI from this PR against from ACS 4.16.0.0:
   
   <img width="1218" alt="Screenshot 2022-02-07 at 2 37 25 PM" 
src="https://user-images.githubusercontent.com/95203/152758216-a42d9770-0bca-4483-bda3-bebb2e60a780.png";>
   <img width="1218" alt="Screenshot 2022-02-07 at 2 37 18 PM" 
src="https://user-images.githubusercontent.com/95203/152758240-9322115f-bb7a-4d9b-9ce3-c9f1af642778.png";>
   
   Another one with the menus collapsed: (notice the colour in dashboard nav, 
isn't fully stretched)
   
   <img width="1219" alt="Screenshot 2022-02-07 at 2 37 43 PM" 
src="https://user-images.githubusercontent.com/95203/152758327-0bbf9f40-ff6d-423a-aa25-e6b04b7369b4.png";>
   
   ![Screenshot 2022-02-07 at 2 37 49 
PM](https://user-images.githubusercontent.com/95203/152758376-314194bb-ab21-499d-b06c-9e4bf17b03b1.png)
   
   Resource view: (note the gutter widths, gaps/margin between cards)
   
   <img width="1218" alt="Screenshot 2022-02-07 at 2 38 31 PM" 
src="https://user-images.githubusercontent.com/95203/152758445-e58ff790-2dcc-43e2-bf3d-51f5a500ddb4.png";>
   
   <img width="1220" alt="Screenshot 2022-02-07 at 2 38 39 PM" 
src="https://user-images.githubusercontent.com/95203/152758423-4a9f3f76-e742-4ba2-be56-a89165d2bba0.png";>
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org