[GitHub] [cloudstack] rohityadavcloud commented on pull request #5151: UI: Upgrade to Vue3 library

[GitBox]

rohityadavcloud commented on pull request #5151:
URL: https://github.com/apache/cloudstack/pull/5151#issuecomment-1050819283


   Overall LGTM but there are still issues;
   
   1. The settings button (blue) is misleading, click this and clicking on save 
is misleading - this doesn't save the theme or UI properties in the mgmt server 
but only for rootadmin in the browser. Do we have this for users too? I think 
users shouldn't be able to see this, and click on save can download a 
properties/json file that gives hint to the admin they need to do something 
with it. What do you think @utchoang @davidjumani @Pearl1594  @nvazquez ?
   <img width="1221" alt="Screenshot 2022-02-25 at 5 56 25 PM" 
src="https://user-images.githubusercontent.com/95203/155715997-96f101e5-cc4e-4c82-b8ab-ac3b94acb6a5.png";>
   
   2. The metrics button/slides causes a mess in most screens - I think the 
table don't have a horizontal scroll bar which is causing this - pl compare 
with the 4.16 UI:
   <img width="1218" alt="Screenshot 2022-02-25 at 5 58 10 PM" 
src="https://user-images.githubusercontent.com/95203/155716181-a981f210-1a42-4a86-919c-dd042116811e.png";>
   
   3. Check all basic UI elements, for ex. the adv search bar for volumes 
doesn't load up (probably some bug). The adv search option do show up in 4.16 
UI:
   <img width="921" alt="Screenshot 2022-02-25 at 6 00 29 PM" 
src="https://user-images.githubusercontent.com/95203/155716282-c831a46a-e32b-4b61-96da-64038b921834.png";>
   
   4. Suggestion -> can we replace the columns dropdown/UI element with a 
button somewhere on the table or as an icon - this takes up too much space and 
messes up the UI view on smaller 13-14" laptops/screens. May be the search bar 
width can be reduced to compensate for that?
   <img width="964" alt="Screenshot 2022-02-25 at 6 01 20 PM" 
src="https://user-images.githubusercontent.com/95203/155716352-c45ace1a-83e9-4091-a2c1-4c84b68017ff.png";>
   
   A full test of UI is necessary to check if any of the actions fail. cc 
@NuxRo @borisstoyanov @vladimirpetrov @nvazquez 
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org