DaanHoogland commented on a change in pull request #5863:
URL: https://github.com/apache/cloudstack/pull/5863#discussion_r801615085



##########
File path: engine/schema/pom.xml
##########
@@ -196,7 +196,7 @@
                                 <configuration>
                                     <checkSignature>true</checkSignature>
 <!--                                    
<url>https://download.cloudstack.org/systemvm/${cs.version}/systemvmtemplate-${cs.version}.${patch.version}-vmware.ova</url>-->
-                                    
<url>https://download.cloudstack.org/testing/systemvmtemplate/{cs.version}/systemvmtemplate-${cs.version}.${patch.version}-vmware.ova</url>
+                                    
<url>https://download.cloudstack.org/testing/systemvmtemplate/${cs.version}/systemvmtemplate-${cs.version}.${patch.version}-vmware.ova</url>

Review comment:
       why these? the one above is the same right?

##########
File path: engine/schema/pom.xml
##########
@@ -183,7 +183,7 @@
                                 <configuration>
                                     <checkSignature>true</checkSignature>
 <!--                                    
<url>https://download.cloudstack.org/systemvm/${cs.version}/systemvmtemplate-${cs.version}.${patch.version}-kvm.qcow2.bz2</url>-->
-                                    
<url>https://download.cloudstack.org/testing/systemvmtemplate/{cs.version}/systemvmtemplate-${cs.version}.${patch.version}-kvm.qcow2.bz2</url>
+                                    
<url>https://download.cloudstack.org/testing/systemvmtemplate/${cs.version}/systemvmtemplate-${cs.version}.${patch.version}-kvm.qcow2.bz2</url>

Review comment:
       already above in comment

##########
File path: engine/schema/pom.xml
##########
@@ -209,7 +209,7 @@
                                 <configuration>
                                     <checkSignature>true</checkSignature>
 <!--                                    
<url>https://download.cloudstack.org/systemvm/${cs.version}/systemvmtemplate-${cs.version}.${patch.version}-xen.vhd.bz2</url>-->
-                                    
<url>https://download.cloudstack.org/testing/systemvmtemplate/{cs.version}/systemvmtemplate-${cs.version}.${patch.version}-xen.vhd.bz2</url>
+                                    
<url>https://download.cloudstack.org/testing/systemvmtemplate/${cs.version}/systemvmtemplate-${cs.version}.${patch.version}-xen.vhd.bz2</url>

Review comment:
       already in comment




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to