DaanHoogland commented on a change in pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#discussion_r805641504
##########
File path:
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx)
throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws
Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: %s", msg));
Review comment:
this line looks good @JoaoJandre , but i suppose you intent is for this
line to be used in some way. As a trace line it should not be read by an
oprator, but only by a developer or maybe a whitebox tester. In those cases
What is the purpose? Not that I -1 this but it seems that a developer would use
this to solve a bug which you don't in this PR so it must be here for whitebox
testing, right? like performance or completeness of the upload service?
can you expand a little on this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
