JoaoJandre commented on a change in pull request #5983:
URL: https://github.com/apache/cloudstack/pull/5983#discussion_r806900885
##########
File path:
services/secondary-storage/server/src/main/java/org/apache/cloudstack/storage/resource/HttpUploadServerHandler.java
##########
@@ -113,6 +113,7 @@ public void channelInactive(ChannelHandlerContext ctx)
throws Exception {
@Override
public void channelRead0(ChannelHandlerContext ctx, HttpObject msg) throws
Exception {
if (msg instanceof HttpRequest) {
+ logger.trace(String.format("HTTP request: %s", msg));
Review comment:
As mentioned in the PR description, we had a problem while uploading
volumes using cURL. However, even after changing the log to TRACE level, it was
not possible for operators to see what was going on there. By adding this log,
we were able to see which headers were being sent (via cURL and UI), which
enabled us to resolve the issue. The log was intended to developers and
operators, so they can see what is happening in the SSVM side. They (operators
and developers/supporters) can change the log level to `TRACE` and see a little
bit more of information regarding the processing in the SSVM. On the other
hand, if no LOG is ever generated (the current state of the code), changing the
LOG level in Log4J does not help anything, and a developer is required to
change the code and patch it in runtime in the SSVM, so one can proceed with
the troubleshooting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
