nvazquez commented on a change in pull request #5992:
URL: https://github.com/apache/cloudstack/pull/5992#discussion_r806669879
##########
File path: test/integration/smoke/test_service_offerings.py
##########
@@ -811,8 +817,28 @@ def test_06_disk_offering_strictness_false(self):
"Check service offering of the VM"
)
+ if fullClone[0].value.lower() == "false":
+ self.updateVmwareSettings(True)
+
return
+ def updateVmwareSettings(self, tearDown):
+ value = "false"
+ if not tearDown:
+ value = "true"
+ if self.hypervisor.lower() == 'vmware':
+ Configurations.update(self.apiclient,
+ "vmware.create.full.clone",
+ value)
+ allStoragePools = StoragePool.list(
+ self.apiclient
+ )
+ for pool in allStoragePools:
Review comment:
Do we need to update all the storage pools? If that is the case I think
we can keep the initial values per storage pool in memory and once the test
finishes, we can revert them back to the initial value
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
