sureshanaparti commented on a change in pull request #6029:
URL: https://github.com/apache/cloudstack/pull/6029#discussion_r812098811
##########
File path:
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/ScaleIOStorageAdaptor.java
##########
@@ -214,12 +214,12 @@ public boolean disconnectPhysicalDisk(String volumePath,
KVMStoragePool pool) {
@Override
public boolean disconnectPhysicalDisk(Map<String, String>
volumeToDisconnect) {
- return true;
+ return false;
}
@Override
public boolean disconnectPhysicalDiskByPath(String localPath) {
Review comment:
The overridden adaptor methods not processing / disconnecting the file
in the local path should return '`false`' as per the comment here.
https://github.com/apache/cloudstack/blob/ac794a0c850480bd75837b003bd065b9a3d6e629/plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/StorageAdaptor.java#L53-L55
The first adaptor which returns _true_ is considered to be the adaptor that
processed the volume disconnection request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
