weizhouapache commented on a change in pull request #5786:
URL: https://github.com/apache/cloudstack/pull/5786#discussion_r821576448
##########
File path:
server/src/main/java/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java
##########
@@ -2583,6 +2598,21 @@ private void createDefaultEgressFirewallRule(final
List<FirewallRule> rules, fin
}
}
+ private void createDefaultEgressIpv6FirewallRule(final List<FirewallRule>
rules, final long networkId) {
+ final NetworkVO network = _networkDao.findById(networkId);
+
if(!_networkOfferingDao.isIpv6Supported(network.getNetworkOfferingId())) {
+ return;
+ }
+ // Since not all networks will IPv6 supported, add a system rule for
IPv6 networks
+ final List<String> sourceCidr = new ArrayList<String>();
+ final List<String> destCidr = new ArrayList<String>();
+ sourceCidr.add(network.getIp6Cidr());
+ destCidr.add(NetUtils.ALL_IP6_CIDRS);
+ final FirewallRule rule = new FirewallRuleVO(null, null, null, null,
"all", networkId, network.getAccountId(), network.getDomainId(),
Purpose.Ipv6Firewall, sourceCidr,
Review comment:
@shwstppr
OK, that sounds good!
ps, 'all' can be replaced with `NetUtils.ALL_PROTO`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
