weizhouapache commented on a change in pull request #5786:
URL: https://github.com/apache/cloudstack/pull/5786#discussion_r828851762
##########
File path: ui/src/views/infra/network/IpRangesTabPublic.vue
##########
@@ -174,6 +186,19 @@
class="form"
>
+ <a-form-item name="iptype" ref="iptype"
:label="$t('label.ip.range.type')" class="form__item">
+ <a-radio-group
+ v-model:value="form.iptype"
+ buttonStyle="solid"
+ @change="selected => { addFormIpType = selected.target.value }">
+ <a-radio-button value="">
+ {{ $t('label.ip.v4') }}
Review comment:
@shwstppr
can IPv4 be set to default ?
##########
File path: ui/src/views/infra/network/IpRangesTabPublic.vue
##########
@@ -186,22 +211,32 @@
<a-select-option v-for="pod in pods" :key="pod.id"
:value="pod.id">{{ pod.name }}</a-select-option>
</a-select>
</a-form-item>
- <a-form-item name="gateway" ref="gateway" :label="$t('label.gateway')"
class="form__item">
- <a-input v-model:value="form.gateway" />
- </a-form-item>
- <a-form-item name="netmask" ref="netmask" :label="$t('label.netmask')"
class="form__item">
- <a-input v-model:value="form.netmask" />
- </a-form-item>
<a-form-item name="vlan" ref="vlan" :label="$t('label.vlan')"
class="form__item" v-if="!basicGuestNetwork">
<a-input v-model:value="form.vlan" />
</a-form-item>
- <a-form-item name="startip" ref="startip" :label="$t('label.startip')"
class="form__item">
- <a-input v-model:value="form.startip" />
- </a-form-item>
- <a-form-item name="endip" ref="endip" :label="$t('label.endip')"
class="form__item">
- <a-input v-model:value="form.endip" />
- </a-form-item>
- <div class="form__item" v-if="!basicGuestNetwork">
+ <div v-if="addFormIpType==='ip6'">
+ <a-form-item name="ip6gateway" ref="ip6gateway"
:label="$t('label.gateway')" class="form__item">
Review comment:
@shwstppr
it looks better to use `label.ip6gateway` instead of `label.ipgateway`
and `label.ip6cidr` as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
