GutoVeronezi commented on pull request #5984:
URL: https://github.com/apache/cloudstack/pull/5984#issuecomment-1062019330


   The tests were performed based on the code changes and the spec (#5935).
   
   I tested the situations with an environment without the changes (ENV-1) and 
another one with the changes (ENV-2). I separeted the CloudMonkey results in 
files to avoid posting a big comment.
   
   
   ### Situations
   
   :heavy_check_mark: I created a VM, waited for management to gather the 
information and restarted it. After restart it, ENV-1 was without the 
informations. ENV-2 had the last collected information.
      - 
[test-restart-ENV-1.md](https://github.com/apache/cloudstack/files/8208256/test-restart-ENV-1.md)
      - 
[test-restart-ENV-2.md](https://github.com/apache/cloudstack/files/8208258/test-restart-ENV-2.md)
   
   :heavy_check_mark: I created a VM and verified in two management nodes. 
ENV-1 presented divergent informations. ENV-2 persented the same information 
for both nodes.
      - 
[test-multiple-mgmt-ENV-1.md](https://github.com/apache/cloudstack/files/8208261/test-multiple-mgmt-ENV-1.md)
      - 
[test-multiple-mgmt-ENV-2.md](https://github.com/apache/cloudstack/files/8208262/test-multiple-mgmt-ENV-2.md)
   
   
   :heavy_check_mark: I tested some combinations of the global configs:
      - 
[test-config-interval-30000-retention-2.md](https://github.com/apache/cloudstack/files/8208264/test-config-interval-30000-retention-2.md)
      - 
[test-config-interval-30000-retention-5.md](https://github.com/apache/cloudstack/files/8208265/test-config-interval-30000-retention-5.md)
      - 
[test-config-interval-60000-retention-5.md](https://github.com/apache/cloudstack/files/8208266/test-config-interval-60000-retention-5.md)
   
   
   
   :heavy_check_mark: UI not showing stopped VMs when seeing metrics unless we 
filter only stopped:
      - 
![test-do-not-show-metrics-of-stopped-vms](https://user-images.githubusercontent.com/38945620/157290963-b29d0eee-d70c-4f55-89c8-990f66882c38.png)
      - 
![test-show-metrics-of-stopped-vms](https://user-images.githubusercontent.com/38945620/157290969-7efbbea3-3cc3-45b1-9913-d9f80e9d37ac.png)
   
   
   :x: Analyzing the database, the column `vm_stats.mgmt_server_id` is storing 
the node's MacAddress, not the management's id.
   
   ---
   
   @joseflauzino Analyzing the new API's return, I think it would be better if 
the element `stats` was ordered by its inner element `timestamp`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to