disk resize NPE, if the new disk offering doesn't have tags, then NPE (cherry picked from commit 21a44e3ed10953b47559f1d8482b0c4aec3f6906)
Signed-off-by: animesh <[email protected]> Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/b269a29f Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/b269a29f Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/b269a29f Branch: refs/heads/4.2 Commit: b269a29f78222d4fbcdf2a6c8c5e74022887fd12 Parents: def926c Author: Edison Su <[email protected]> Authored: Fri Aug 30 18:15:20 2013 -0700 Committer: animesh <[email protected]> Committed: Tue Sep 3 16:31:41 2013 -0700 ---------------------------------------------------------------------- server/src/com/cloud/storage/VolumeManagerImpl.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/cloudstack/blob/b269a29f/server/src/com/cloud/storage/VolumeManagerImpl.java ---------------------------------------------------------------------- diff --git a/server/src/com/cloud/storage/VolumeManagerImpl.java b/server/src/com/cloud/storage/VolumeManagerImpl.java index 85a19ca..1d6b44f 100644 --- a/server/src/com/cloud/storage/VolumeManagerImpl.java +++ b/server/src/com/cloud/storage/VolumeManagerImpl.java @@ -1144,7 +1144,7 @@ public class VolumeManagerImpl extends ManagerBase implements VolumeManager { } if (diskOffering.getTags() != null) { - if (!newDiskOffering.getTags().equals(diskOffering.getTags())) { + if (newDiskOffering.getTags() == null || !newDiskOffering.getTags().equals(diskOffering.getTags())) { throw new InvalidParameterValueException( "Tags on new and old disk offerings must match"); }
