rohityadavcloud commented on a change in pull request #6118:
URL: https://github.com/apache/cloudstack/pull/6118#discussion_r826829833
##########
File path: server/src/main/java/com/cloud/user/DomainManagerImpl.java
##########
@@ -220,11 +220,10 @@ public DomainVO doInTransaction(TransactionStatus status)
{
_resourceCountDao.createResourceCounts(domain.getId(),
ResourceLimit.ResourceOwnerType.Domain);
CallContext.current().putContextParameter(Domain.class,
domain.getUuid());
- _messageBus.publish(_name, MESSAGE_ADD_DOMAIN_EVENT,
PublishScope.LOCAL, domain.getId());
return domain;
}
});
-
+ _messageBus.publish(_name, MESSAGE_ADD_DOMAIN_EVENT,
PublishScope.LOCAL, domain.getId());
Review comment:
Just wondering if this is cause for concern, what if the transaction
fails for some reason @Pearl1594, should we check for that (for ex. the domain
ID is not null) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
