nvazquez commented on a change in pull request #6164:
URL: https://github.com/apache/cloudstack/pull/6164#discussion_r835471732
##########
File path:
server/src/main/java/com/cloud/storage/listener/StoragePoolMonitor.java
##########
@@ -108,10 +108,12 @@ public void processConnect(Host host, StartupCommand cmd,
boolean forRebalance)
List<StoragePoolVO> zoneStoragePoolsByAnyHypervisor =
_poolDao.findZoneWideStoragePoolsByHypervisor(host.getDataCenterId(),
HypervisorType.Any);
pools.addAll(zoneStoragePoolsByAnyHypervisor);
+ // get the disabled pools list if global setting is true.
+ if (StorageManager.MountDisabledStoragePool.value()) {
+
pools.addAll(_poolDao.findDisabledPoolsByScope(host.getDataCenterId(), null,
null, ScopeType.ZONE));
Review comment:
Cluster-wide storage pools are not considered?
##########
File path:
engine/components-api/src/main/java/com/cloud/storage/StorageManager.java
##########
@@ -155,6 +155,15 @@
ConfigKey<String> PreferredStoragePool = new
ConfigKey<String>(String.class, "preferred.storage.pool", "Advanced", "",
"The UUID of preferred storage pool for allocation.", true,
ConfigKey.Scope.Account, null);
+ ConfigKey<Boolean> MountDisabledStoragePool = new
ConfigKey<>(Boolean.class,
+ "mount.disabled.storage.pool",
+ "Storage",
+ "false",
+ "Mount disabled storage pool after node reboot",
+ true,
+ ConfigKey.Scope.Cluster,
Review comment:
Shouldn't this scope be set to StoragePool? If not, please update the
configuration description mentioning that it impacts all the storage pools in
the cluster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
