weizhouapache commented on pull request #6168: URL: https://github.com/apache/cloudstack/pull/6168#issuecomment-1080507935
> > > quite frankly, I think this is due to technical debt and we should not fix this but phase those configs defined in Config.java out. > > > > > > @DaanHoogland reset configuration is already supported in 4.16.1 (see #4230). this is a bug fix . > > It is supported for modern ConfigKey entries, this is extra. I think any Config that needs resetting should be modernised. @DaanHoogland in my opinion, from cloudstack user's view, they should be same: all can be set, updated and reset, no matter they are defined by ConfigKey or in Config.java. It would be good to move configurations defined in Config.java to ConfigKey, but it is not prerequisite for reset configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
