slavkap commented on a change in pull request #3724:
URL: https://github.com/apache/cloudstack/pull/3724#discussion_r837118183
##########
File path: server/src/main/java/com/cloud/storage/snapshot/SnapshotManager.java
##########
@@ -59,6 +59,8 @@
public static final ConfigKey<Boolean> BackupSnapshotAfterTakingSnapshot =
new ConfigKey<Boolean>(Boolean.class, "snapshot.backup.to.secondary",
"Snapshots", "true",
"Indicates whether to always backup primary storage snapshot to
secondary storage. Keeping snapshots only on Primary storage is applicable for
KVM + Ceph only.", false, ConfigKey.Scope.Global, null);
+ public static final ConfigKey<Boolean> VMsnapshotKVM = new
ConfigKey<>(Boolean.class, "kvm.vmstoragesnapshot.enabled", "Snapshots",
"false", "For live snapshot of virtual machine instance on KVM hypervisor
without memory. Requieres qemu version 1.6+ (on NFS or Local file system) and
qemu-guest-agent installed on guest VM", true, ConfigKey.Scope.Global, null);
Review comment:
@nvazquez, I will rename it, but why limit this to a Zone?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
