nvazquez commented on a change in pull request #6164:
URL: https://github.com/apache/cloudstack/pull/6164#discussion_r837479377
##########
File path:
server/src/main/java/com/cloud/storage/listener/StoragePoolMonitor.java
##########
@@ -108,10 +108,12 @@ public void processConnect(Host host, StartupCommand cmd,
boolean forRebalance)
List<StoragePoolVO> zoneStoragePoolsByAnyHypervisor =
_poolDao.findZoneWideStoragePoolsByHypervisor(host.getDataCenterId(),
HypervisorType.Any);
pools.addAll(zoneStoragePoolsByAnyHypervisor);
+ // get the disabled pools list if global setting is true.
+ if (StorageManager.MountDisabledStoragePool.value()) {
+
pools.addAll(_poolDao.findDisabledPoolsByScope(host.getDataCenterId(), null,
null, ScopeType.ZONE));
+ }
+
for (StoragePoolVO pool : pools) {
- if (pool.getStatus() != StoragePoolStatus.Up) {
Review comment:
Actually not only Up state since you have added the Disabled pools as
well, actually my suggestion above is not correct, should be:
````
if (pool.getStatus() != StoragePoolStatus.Up ||
(StorageManager.MountDisabledStoragePool.value() && pool.getStatus() !=
StoragePoolStatus.Disabled && pool.getStatus() != StoragePoolStatus.Up)) {
continue;
}
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
