ravening commented on a change in pull request #6164:
URL: https://github.com/apache/cloudstack/pull/6164#discussion_r837315264



##########
File path: 
server/src/main/java/com/cloud/storage/listener/StoragePoolMonitor.java
##########
@@ -108,10 +108,12 @@ public void processConnect(Host host, StartupCommand cmd, 
boolean forRebalance)
                 List<StoragePoolVO> zoneStoragePoolsByAnyHypervisor = 
_poolDao.findZoneWideStoragePoolsByHypervisor(host.getDataCenterId(), 
HypervisorType.Any);
                 pools.addAll(zoneStoragePoolsByAnyHypervisor);
 
+                // get the disabled pools list if global setting is true.
+                if (StorageManager.MountDisabledStoragePool.value()) {
+                    
pools.addAll(_poolDao.findDisabledPoolsByScope(host.getDataCenterId(), null, 
null, ScopeType.ZONE));

Review comment:
       @weizhouapache when we set the status of the storage pool as disabled, 
it will not be used for vm allocation but it will be still mounted/accessible 
for the vm's. When the node reboots, all the disabled pools will not be mounted 
and as a result the volume of the vm will not be accessible.
   
   My understanding of the cluster wide pool is that it will be mounted on the 
hosts within the same cluster right? The same pool will not be mounted on the 
nodes of different cluster.
   
   
   Lets say we have three clusters. A, B and C.
   I want the disabled pool to be mounted on all three clusters rather than 
just on A or B or C. Thats why I am searching for zone wide pools




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to