DaanHoogland commented on a change in pull request #6188:
URL: https://github.com/apache/cloudstack/pull/6188#discussion_r840422223
##########
File path: systemvm/debian/opt/cloud/bin/configure.py
##########
@@ -162,6 +162,7 @@ def add_rule(self):
" -A FIREWALL_%s" % self.ip +
" -s %s " % cidr +
" -p %s " % rule['protocol'] +
+ " -m %s " % rule['protocol'] +
Review comment:
maybe we should start using format strings
```suggestion
" -m {rule['protocol']} " +
```
not a biggy or in scope for this PR, just a thought on systemvm python code
in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
