GutoVeronezi commented on PR #5984:
URL: https://github.com/apache/cloudstack/pull/5984#issuecomment-1089105927

   I re-ran the manual tests (one of the results below). The feature seems 
working fine to me.
   
   ---
   
   Test with 15 seconds of interval and 1 minute of retention, with 2 MGMT:
   
   **Note:** the stats are ordered by the field `timestamp` now.
   
   ```
   (lab) 🐱 > list configurations name=vm.stats
   {
     "configuration": [
       {
         "category": "Advanced",
         "description": "When set to 'true', VM metrics(NetworkReadKBs, 
NetworkWriteKBs, DiskWriteKBs, DiskReadKBs, DiskReadIOs and DiskWriteIOs) that 
are collected from the hypervisor are summed before being returned.On the other 
hand, when set to 'false', the VM metrics API will just display the latest 
metrics collected.",
         "isdynamic": true,
         "name": "vm.stats.increment.metrics",
         "value": "true"
       },
       {
         "category": "Advanced",
         "description": "The interval (in milliseconds) when vm stats are 
retrieved from agents.",
         "isdynamic": false,
         "name": "vm.stats.interval",
         "value": "15000"
       },
       {
         "category": "Advanced",
         "description": "The maximum time (in minutes) for keeping VM stats 
records in the database. The VM stats cleanup process will be disabled if this 
is set to 0 or less than 0.",
         "isdynamic": true,
         "name": "vm.stats.max.retention.time",
         "value": "1"
       }
     ],
     "count": 3
   }
   (lab) 🐱 > list virtualmachinesusagehistory 
id=167e5918-4762-4536-a526-942fa2fc62cb 
   {
     "count": 1,
     "virtualmachine": [
       {
         "id": "167e5918-4762-4536-a526-942fa2fc62cb",
         "name": "i-2-113-VM",
         "stats": [
           {
             "cpuused": "15.78%",
             "diskiopstotal": 0,
             "diskioread": 0,
             "diskiowrite": 0,
             "diskkbsread": 0,
             "diskkbswrite": 0,
             "memoryintfreekbs": 0,
             "memorykbs": 524288,
             "memorytargetkbs": 524288,
             "networkkbsread": 0,
             "networkkbswrite": 0,
             "networkread": "0.00 MB",
             "networkwrite": "0.00 MB",
             "timestamp": "2022-04-05T17:37:26+0000"
           },
           {
             "cpuused": "16.8%",
             "diskiopstotal": 0,
             "diskioread": 0,
             "diskiowrite": 0,
             "diskkbsread": 0,
             "diskkbswrite": 0,
             "memoryintfreekbs": 0,
             "memorykbs": 524288,
             "memorytargetkbs": 524288,
             "networkkbsread": 0,
             "networkkbswrite": 0,
             "networkread": "0.00 MB",
             "networkwrite": "0.00 MB",
             "timestamp": "2022-04-05T17:37:29+0000"
           },
           {
             "cpuused": "16.08%",
             "diskiopstotal": 0,
             "diskioread": 0,
             "diskiowrite": 0,
             "diskkbsread": 0,
             "diskkbswrite": 0,
             "memoryintfreekbs": 0,
             "memorykbs": 524288,
             "memorytargetkbs": 524288,
             "networkkbsread": 0,
             "networkkbswrite": 0,
             "networkread": "0.00 MB",
             "networkwrite": "0.00 MB",
             "timestamp": "2022-04-05T17:37:41+0000"
           },
           {
             "cpuused": "16.18%",
             "diskiopstotal": 0,
             "diskioread": 0,
             "diskiowrite": 0,
             "diskkbsread": 0,
             "diskkbswrite": 0,
             "memoryintfreekbs": 0,
             "memorykbs": 524288,
             "memorytargetkbs": 524288,
             "networkkbsread": 0,
             "networkkbswrite": 0,
             "networkread": "0.00 MB",
             "networkwrite": "0.00 MB",
             "timestamp": "2022-04-05T17:37:44+0000"
           },
           {
             "cpuused": "16.2%",
             "diskiopstotal": 0,
             "diskioread": 0,
             "diskiowrite": 0,
             "diskkbsread": 0,
             "diskkbswrite": 0,
             "memoryintfreekbs": 0,
             "memorykbs": 524288,
             "memorytargetkbs": 524288,
             "networkkbsread": 0,
             "networkkbswrite": 0,
             "networkread": "0.00 MB",
             "networkwrite": "0.00 MB",
             "timestamp": "2022-04-05T17:37:57+0000"
           },
           {
             "cpuused": "16.88%",
             "diskiopstotal": 0,
             "diskioread": 0,
             "diskiowrite": 0,
             "diskkbsread": 0,
             "diskkbswrite": 0,
             "memoryintfreekbs": 0,
             "memorykbs": 524288,
             "memorytargetkbs": 524288,
             "networkkbsread": 0,
             "networkkbswrite": 0,
             "networkread": "0.00 MB",
             "networkwrite": "0.00 MB",
             "timestamp": "2022-04-05T17:38:00+0000"
           },
           {
             "cpuused": "16.13%",
             "diskiopstotal": 0,
             "diskioread": 0,
             "diskiowrite": 0,
             "diskkbsread": 0,
             "diskkbswrite": 0,
             "memoryintfreekbs": 0,
             "memorykbs": 524288,
             "memorytargetkbs": 524288,
             "networkkbsread": 0,
             "networkkbswrite": 0,
             "networkread": "0.00 MB",
             "networkwrite": "0.00 MB",
             "timestamp": "2022-04-05T17:38:12+0000"
           },
           {
             "cpuused": "14.47%",
             "diskiopstotal": 0,
             "diskioread": 0,
             "diskiowrite": 0,
             "diskkbsread": 0,
             "diskkbswrite": 0,
             "memoryintfreekbs": 0,
             "memorykbs": 524288,
             "memorytargetkbs": 524288,
             "networkkbsread": 0,
             "networkkbswrite": 0,
             "networkread": "0.00 MB",
             "networkwrite": "0.00 MB",
             "timestamp": "2022-04-05T17:38:15+0000"
           }
         ]
       }
     ]
   }
   
   ```
   ---
   
   The column `vm_stats.mgmt_server_id` is storing the management server's id 
now:
   
   ```sql
   MariaDB [cloud]> select * from mshost;
   
+----+----------------+---------------+-----------------------------+--------------------------------------+-------+-------------------+-----------------+--------------+---------------------+---------+-------------+
   | id | msid           | runid         | name                        | uuid   
                              | state | version           | service_ip      | 
service_port | last_update         | removed | alert_count |
   
+----+----------------+---------------+-----------------------------+--------------------------------------+-------+-------------------+-----------------+--------------+---------------------+---------+-------------+
   |  1 | 90520745551922 | 1649179172554 | cloudstack-lab-management-1 | 
cd30ed1b-daed-4f23-bd5a-439ed609bf13 | Up    | 4.17.0.0-SNAPSHOT | 
192.168.201.150 |         9090 | 2022-04-05 17:38:12 | NULL    |           0 |
   |  3 | 90520746808830 | 1649179414017 | cloudstack-lab-management-2 | 
ea6b28f8-8511-43f8-bff7-03a9c3fc01d8 | Up    | 4.17.0.0-SNAPSHOT | 
192.168.201.151 |         9090 | 2022-04-05 17:38:11 | NULL    |           0 |
   
+----+----------------+---------------+-----------------------------+--------------------------------------+-------+-------------------+-----------------+--------------+---------------------+---------+-------------+
   2 rows in set (0.001 sec)
   
   MariaDB [cloud]> select * from vm_stats;
   
+-----+-------+----------------+---------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
   | id  | vm_id | mgmt_server_id | timestamp           | vm_stats_data         
                                                                                
                                                                                
                                                                                
          |
   
+-----+-------+----------------+---------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
   | 136 |   113 |              1 | 2022-04-05 17:37:26 | 
{"vmId":113,"cpuUtilization":15.784281486353175,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"}
 |
   | 137 |   113 |              3 | 2022-04-05 17:37:29 | 
{"vmId":113,"cpuUtilization":16.801075268817204,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"}
 |
   | 138 |   113 |              1 | 2022-04-05 17:37:41 | 
{"vmId":113,"cpuUtilization":16.078753076292042,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"}
 |
   | 139 |   113 |              3 | 2022-04-05 17:37:44 | 
{"vmId":113,"cpuUtilization":16.183412002697235,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"}
 |
   | 140 |   113 |              1 | 2022-04-05 17:37:57 | 
{"vmId":113,"cpuUtilization":16.203322914953116,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"}
 |
   | 141 |   113 |              3 | 2022-04-05 17:38:00 | 
{"vmId":113,"cpuUtilization":16.87624090006618,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"}
  |
   | 142 |   113 |              1 | 2022-04-05 17:38:12 | 
{"vmId":113,"cpuUtilization":16.1276982879828,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"}
   |
   | 143 |   113 |              3 | 2022-04-05 17:38:15 | 
{"vmId":113,"cpuUtilization":14.468924695823743,"networkReadKBs":0.0,"networkWriteKBs":0.0,"diskReadIOs":0.0,"diskWriteIOs":0.0,"diskReadKBs":0.0,"diskWriteKBs":0.0,"memoryKBs":524288.0,"intFreeMemoryKBs":524288.0,"targetMemoryKBs":524288.0,"numCPUs":1,"entityType":"vm"}
 |
   
+-----+-------+----------------+---------------------+---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------+
   8 rows in set (0.001 sec)
   ```
   
   ---
   
   @nvazquez can we re-run the smoke tests for this one?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to