weizhouapache commented on PR #5902: URL: https://github.com/apache/cloudstack/pull/5902#issuecomment-1099469557
@SadiJr I have tested this PR. unforunately the issue you mentioned in description is not fixed. I have made some changes to your code. see https://github.com/weizhouapache/cloudstack/commit/18137e105cefbc163a1bf8cad4961c30239762dd what I have tested are 1. global setting `system.vm.public.ip.reservation.mode.strictness` is set to `false` - 1.1 Free IPs in the range can be listed (OK to me) - 1.2 Free IPs in the range can be associated to isolated networks (OK to me) - 1.3 Allocated IPs (in step 1.2) are listed in the "Public IP Addresses" tab in the network details page. (OK to me) 2. global setting `system.vm.public.ip.reservation.mode.strictness` is set to `true` - 2.1 Free IPs in the range can NOT be listed (OK to me) - 2.2 Free IPs in the range can NOT be associated to isolated networks by `cmk` (OK to me) - 2.3 Allocated IPs (in step 1.2) are listed in the "Public IP Addresses" tab in the network details page. (OK to me) other than that, I change the global configuration to dynamic, so it is not required to restart management server when you change the value. Could you please test it ? If it works, please advise if you add the commit to your PR or I create a new PR which including all changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
