BryanMLima opened a new pull request, #6269:
URL: https://github.com/apache/cloudstack/pull/6269

   ### Description
   
   This PR aims to improve the error message while trying to update the storage 
tags of a Disk Offering when none of the Primary Storages have that set of 
storage tags. The current behavior only showed the ID of the Disk Offering and 
Storage Pools. This PR improves the error message to display the UUID of these 
components, as well as their names and the volumes using that Disk Offering. 
Furthermore, it was added unit tests for the modified method 
`updateOfferingTagsIfIsNotNull`.
   
   ### Types of changes
   
   - [ ] Breaking change (fix or feature that would cause existing 
functionality to change)
   - [ ] New feature (non-breaking change which adds functionality)
   - [ ] Bug fix (non-breaking change which fixes an issue)
   - [x] Enhancement (improves an existing feature and functionality)
   - [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
   
   ### Feature/Enhancement Scale or Bug Severity
   
   #### Feature/Enhancement Scale
   
   - [ ] Major
   - [x] Minor
   
   ### Screenshots (if appropriate):
   
![image](https://user-images.githubusercontent.com/42067040/163455463-518f6668-b944-479f-889f-2b9598c80e20.png)
   
   ### How Has This Been Tested?
   This was tested in a local lab trying to update the storage tags of a disk 
offering, when none of the primary storages had that set of storage tags. The 
error message returned is in the Screenshots section.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to