GutoVeronezi commented on code in PR #6269:
URL: https://github.com/apache/cloudstack/pull/6269#discussion_r856615470
##########
engine/schema/src/main/java/com/cloud/storage/dao/VolumeDao.java:
##########
@@ -131,4 +131,12 @@ public interface VolumeDao extends GenericDao<VolumeVO,
Long>, StateDao<Volume.S
* Updates the disk offering for the given volume.
*/
void updateDiskOffering(long volumeId, long diskOfferingId);
+
+ /**
+ * Get volumes by the disk offering ID.
Review Comment:
```suggestion
* Gets volumes by the disk offering ID.
```
##########
server/src/main/java/com/cloud/configuration/ConfigurationManagerImpl.java:
##########
@@ -3801,7 +3803,15 @@ protected void updateOfferingTagsIfIsNotNull(String
tags, DiskOfferingVO diskOff
for (StoragePoolVO storagePoolVO : pools) {
List<String> tagsOnPool =
storagePoolTagDao.getStoragePoolTags(storagePoolVO.getId());
if (CollectionUtils.isEmpty(tagsOnPool) ||
!tagsOnPool.containsAll(listOfTags)) {
- throw new
InvalidParameterValueException(String.format("There are active volumes using
offering [%s], and the pools [%s] don't have the new tags",
diskOffering.getId(), pools));
+ String offeringUuid =
_diskOfferingDao.findById(diskOffering.getId()).getUuid();
+ List<VolumeVO> volumes =
_volumeDao.findByDiskOfferingId(diskOffering.getId());
+ List<String> listOfVolumesNamesAndUuid = new
ArrayList<>();
+ for (VolumeVO volumeVO : volumes) {
+ listOfVolumesNamesAndUuid.add(String.format("Name:
%s, UUID: %s",volumeVO.getName(), volumeVO.getUuid()));
+ }
+ throw new
InvalidParameterValueException(String.format("There are active volumes using
the disk offering [Name: %s, UUID: %s], and the pool [Name: %s, UUID: %s]
doesn't have the new tags. " +
Review Comment:
We can use `ReflectionToStringBuilderUtils` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
