sureshanaparti commented on PR #4774:
URL: https://github.com/apache/cloudstack/pull/4774#issuecomment-1105073555
> @sureshanaparti please advise if this is ready after your testing, thanks
@nvazquez @soreana test LGTM
Manually covered with the following tests, and verified the public templates
access restricted to other domains when the global or the respective domain's
config "share.public.templates.with.other.domains" is set to false.
- Created domains: Domain1 and Domain2.
- Created accounts/users: Domain1Admin and Domain2Admin.
- Registered public templates from macchinina-admin from Admin account.
- Registered public templates from macchinina-domain1, centos65-domain1 from
Domain1Admin account.
- Registered public templates from macchinina-domain2, centos65-domain2 from
Domain2Admin account.
**Tests with global level setting:**
(i) The global config "share.public.templates.with.other.domains" is set to
true by default, and all the public templates of domain1/domain2 are listed for
admin, domain1 admin, and domain2 admin.
(ii) Set the global config "restrict.public.template.access.to.domain" to
false. Verified the public templates of domain1 are not listed for domain2
admin, and the public templates of domain2 are not listed for domain1 admin.
All the public templates are listed for root admin.
**Tests with domain level setting:**
(i) Set Domain1 config "_share.public.templates.with.other.domains_": true
and Domain2 config "_share.public.templates.with.other.domains_": false
=> All the public templates are listed for root admin.
=> The public templates of domain1 are listed for domain2 admin.
=> The public templates of domain2 are not listed for domain1 admin.
(ii) Set Domain1 config "_share.public.templates.with.other.domains_": false
and Domain2 config "_share.public.templates.with.other.domains_": true
=> All the public templates are listed for root admin.
=> The public templates of domain1 are not listed for domain2 admin.
=> The public templates of domain2 are listed for domain1 admin.
(iii) Set Domain1 config "_share.public.templates.with.other.domains_": true
and Domain2 config "_share.public.templates.with.other.domains_": true
=> All the public templates are listed for root admin.
=> The public templates of domain1 are listed for domain2 admin
=> The public templates of domain2 are listed for domain1 admin
(iv) Set Domain1 config "_share.public.templates.with.other.domains_": false
and Domain2 config "_share.public.templates.with.other.domains_": false
=> All the public templates are listed for root admin.
=> The public templates of domain1 are not listed for domain2 admin
=> The public templates of domain2 are not listed for domain1 admin
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
