GabrielBrascher commented on code in PR #6356:
URL: https://github.com/apache/cloudstack/pull/6356#discussion_r864871245
##########
utils/src/main/java/com/cloud/utils/component/ComponentContext.java:
##########
@@ -72,8 +72,14 @@ public static void initComponentsLifeCycle() {
Map<String, ComponentMethodInterceptable> interceptableComponents =
getApplicationContext().getBeansOfType(ComponentMethodInterceptable.class);
for (Map.Entry<String, ComponentMethodInterceptable> entry :
interceptableComponents.entrySet()) {
- Object bean = getTargetObject(entry.getValue());
- beanFactory.configureBean(bean, entry.getKey());
+ try {
+ Object bean = getTargetObject(entry.getValue());
+ beanFactory.configureBean(bean, entry.getKey());
+ } catch (Throwable e){
Review Comment:
A `catch Throwable` is a bit too much of a Pokémon catch (them all).
Did you reproduce such issues and discovered what exceptions are thrown?
As far as I know it would be raised an `BeansException`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
