DaanHoogland commented on code in PR #6394:
URL: https://github.com/apache/cloudstack/pull/6394#discussion_r875645703
##########
framework/security/src/main/java/org/apache/cloudstack/framework/security/keystore/KeystoreManagerImpl.java:
##########
@@ -109,15 +109,15 @@ public byte[] getKeystoreBits(String name, String
aliasForCertificateInStore, St
try {
return CertificateHelper.buildAndSaveKeystore(certs,
storePassword);
} catch (KeyStoreException e) {
- s_logger.warn("Unable to build keystore for " + name + " due to
KeyStoreException");
+ s_logger.warn("Unable to build keystore for " + name + " due to
KeyStoreException", e);
Review Comment:
Doing like this,
```suggestion
s_logger.warn(String.format("Unable to build keystore for %s due
to %s", name, e.getClass().getSimpleName()));
if (s_logger.isDebugEnabled()) {
s_logger.debug(String.format("Unable to build keystore for
%s due to %s", name, e.getClass().getSimpleName()), e);
}
```
the catch clauses can be unified to one
```
} catch (KeyStoreException | CertificateException |
InvalidKeySpecException | IOException e) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
