sureshanaparti commented on code in PR #6423:
URL: https://github.com/apache/cloudstack/pull/6423#discussion_r885303169
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -1414,6 +1414,10 @@ private void configureAgentHooks(final Map<String,
Object> params) {
s_logger.debug("agent.hooks.libvirt_vm_on_stop.method is " +
_agentHooksVmOnStopMethod);
}
+ public boolean isUefiPropertiesFileSet() {
Review Comment:
@nvazquez UEFI properties are loaded from this file while configuring the
resource, no need to check again for this file, instead check for properties
loaded or not. Also, re-use this method in _loadUefiProperties()_ method below
for the same condition. Thanks.
```suggestion
public boolean isUefiPropertiesLoaded() {
return _uefiProperties != null &&
_uefiProperties.getProperty("guest.loader.legacy") != null
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
