DaanHoogland commented on code in PR #6408:
URL: https://github.com/apache/cloudstack/pull/6408#discussion_r890852596
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -1831,7 +1917,7 @@ public void cleanupStorageJobs() {
cleanupVolumeDuringSnapshotFailure(work.getVolumeId(),
work.getSnapshotId());
}
} catch (Exception e) {
- s_logger.debug("clean up job failure, will continue", e);
+ s_logger.error(String.format("Clean up job failed due to [%s].
Will continue with other clean up jobs.", e.getMessage()), e);
Review Comment:
please do not log an exception on non fatal errors. if needed add a debug
statement that logs the stacktrace but keep info and up clean.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
