DaanHoogland commented on code in PR #6408:
URL: https://github.com/apache/cloudstack/pull/6408#discussion_r890856649
##########
engine/orchestration/src/main/java/org/apache/cloudstack/engine/orchestration/VolumeOrchestrator.java:
##########
@@ -1235,12 +1280,10 @@ public Volume migrateVolume(Volume volume, StoragePool
destPool) throws StorageU
}
}
return result.getVolume();
- } catch (InterruptedException e) {
- s_logger.debug("migrate volume failed", e);
- throw new CloudRuntimeException(e.getMessage());
- } catch (ExecutionException e) {
- s_logger.debug("migrate volume failed", e);
- throw new CloudRuntimeException(e.getMessage());
+ } catch (InterruptedException | ExecutionException e) {
+ String msg = String.format("Volume [%s] migration failed due to
[%s].", volumeToString, e.getMessage());
+ s_logger.error(msg, e);
Review Comment:
please don´t log error with exception. If need be add a debug that logs the
stacktrace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
