DaanHoogland commented on PR #6425: URL: https://github.com/apache/cloudstack/pull/6425#issuecomment-1161767654
> @DaanHoogland out of 4 code smells, 3 are for number of params in method. And one is for InsufficientCapacityException not used by the method. I didn't add it to method and not very keen refactoring unrelated codebase in this PR. I've tried to make changes to minimize duplication @shwstppr, only one was about number of parameters, but I don´t mind the remaining two, You've addressed the most important ones in response to @nvazquez' comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
