weizhouapache commented on code in PR #6413:
URL: https://github.com/apache/cloudstack/pull/6413#discussion_r907320520
##########
plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java:
##########
@@ -331,12 +331,7 @@ public boolean configure(String name, Map<String, Object>
params) throws Configu
_storage.configure("StorageLayer", params);
}
- value = _configDao.getValue(Config.VmwareCreateFullClone.key());
- if (value == null) {
- _fullCloneFlag = false;
- } else {
- _fullCloneFlag = Boolean.parseBoolean(value);
- }
+ _fullCloneFlag = StorageManager.VmwareCreateCloneFull.value();
Review Comment:
@DaanHoogland
is it possible `_fullCloneFlag` is null ?
##########
plugins/hypervisors/xenserver/src/main/java/com/cloud/hypervisor/XenServerGuru.java:
##########
@@ -197,6 +193,14 @@ public Pair<Boolean, Long> getCommandHostDelegation(long
hostId, Command cmd) {
logger.debug("We are returning the default host to execute
commands because the target hypervisor of the source data is not XenServer.");
return defaultHostToExecuteCommands;
}
+ // only now can we decide, now we now we're only deciding for ourselves
Review Comment:
make sense
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
