sureshanaparti commented on code in PR #6552:
URL: https://github.com/apache/cloudstack/pull/6552#discussion_r922195719
##########
engine/schema/src/main/java/com/cloud/upgrade/dao/Upgrade41700to41710.java:
##########
@@ -83,4 +96,25 @@ public void updateSystemVmTemplates(Connection conn) {
throw new CloudRuntimeException("Failed to find / register
SystemVM template(s)");
}
}
+
+ private void updateStorageType() {
+ storageDao = new PrimaryDataStoreDaoImpl();
+ List<StoragePoolVO> storPoolPools =
storageDao.findPoolsByProvider("StorPool");
Review Comment:
> Hi, @sureshanaparti. Thanks for the code review!
> I don't want to add a dependency for the StorPool plugin to use one
string. Also, I didn't check it, but I think there will be a circular
dependency problem here if I add the plugin as a dependency
fine, ensure the provider string is correct/the same as in the StorPool
plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
