SadiJr opened a new pull request, #6580: URL: https://github.com/apache/cloudstack/pull/6580
### Description Using the VMWare hypervisor, with the Veeam plugin active, it is not possible to remove backups. Instead, an exception is thrown in ACS, and the only procedure that allows the removal of backups is to remove the VM from the Backup Offering, which causes all backups for that VM to be removed. Through Veeam's documentation and user forum, it was discovered that it does not allow the removal of specific restore points. Instead, the entire backup chain is removed, leaving only the job in Veeam. To address this limitation, a new parameter has been added to the `deleteBackup` API to allow users to remove the complete Veeam backup chain. So, when removing a backup, users can pass the `forced` parameter as `true`, to remove all the backup chain, but keeping the VM in the Backup Offering. Otherwise, an exception will be thrown notifying the user of this Veeam limitation and the `forced` option. ### Types of changes - [ ] Breaking change (fix or feature that would cause existing functionality to change) - [ ] New feature (non-breaking change which adds functionality) - [ ] Bug fix (non-breaking change which fixes an issue) - [x] Enhancement (improves an existing feature and functionality) - [ ] Cleanup (Code refactoring and cleanup, that may add test cases) ### Feature/Enhancement Scale or Bug Severity #### Feature/Enhancement Scale - [ ] Major - [x] Minor ### How Has This Been Tested? It was tested in a local lab: 1. I created a new VM and attached this VM to a Backup Offering; 2. I performed two manual backups; 3. I attempted (using CLI) to delete one of these backups; 4. Before, an exception was thrown, forcing the user to remove the VM from Backup Offering; 5. Now, users can use `forced` option to remove the entire backup chain but keep VM in Backup Offering, plus the error message has been improved. Also, I added new unit tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
