mlsorensen commented on code in PR #6522:
URL: https://github.com/apache/cloudstack/pull/6522#discussion_r942592157
##########
core/src/main/java/org/apache/cloudstack/storage/to/VolumeObjectTO.java:
##########
@@ -357,4 +366,22 @@ public String getvSphereStoragePolicyId() {
public void setvSphereStoragePolicyId(String vSphereStoragePolicyId) {
this.vSphereStoragePolicyId = vSphereStoragePolicyId;
}
+
+ public String getEncryptFormat() { return encryptFormat; }
+
+ public void setEncryptFormat(String encryptFormat) { this.encryptFormat =
encryptFormat; }
+
+ public byte[] getPassphrase() { return passphrase; }
+
+ public void setPassphrase(byte[] passphrase) { this.passphrase =
passphrase; }
Review Comment:
Reading through the code conventions, there is emphasis on "should" versus
"must", and that readability comes before convention. The block convention is a
"should" item, and changing the convention in this class when looked on as a
whole will probably reduce the cleanliness/readability of it.
I'm willing to change the style here, but absent any further feedback, I
would opt to maintain the existing convention of this class and leave it as-is
rather than mixing conventions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
