DaanHoogland commented on PR #6522: URL: https://github.com/apache/cloudstack/pull/6522#issuecomment-1228308289
> > @mlsorensen got the PR close notification - are you opening a new one? > > Accident, I guess? > > I was able to address a few Sonar results. Most of these seem to be from existing methods being pulled in as too complex, due to adding one line, or something along those lines. I'm hesitant to refactor all of these for this PR. Of course @mlsorensen , do not address complex methods unless you added conditions or loops to them, We have too much back-lag to address all of that in every PR and shouldn't mix that work with fixes or new functionality. If we don't add to the mess, that should be good enough for a PR that doesn't specifically address these issues. thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
