DK101010 commented on PR #6012: URL: https://github.com/apache/cloudstack/pull/6012#issuecomment-1283753064
> @DK101010 there are still some comments like [#6012 (comment)](https://github.com/apache/cloudstack/pull/6012#discussion_r999075541) and https://github.com/apache/cloudstack/pull/6012/files#r849150798 (and similar) I think these are easy refactorrings for a lot clearer code > > the two sonar issues where coplexity is 16 instead of allowed 15 are both due to an extra condition that could be extracted. It would be cleaner to extract those. 72 or 41 I can not blame on you of course so feel free to extract anything there or not. @DaanHoogland After the merge and not being able to test it in my environment, I'm worried that the feature won't work anymore, so I'd rather not to change the methods. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
