weizhouapache commented on code in PR #6839:
URL: https://github.com/apache/cloudstack/pull/6839#discussion_r1002077253
##########
engine/storage/src/main/java/org/apache/cloudstack/storage/allocator/ClusterScopeStoragePoolAllocator.java:
##########
@@ -107,7 +107,7 @@ protected List<StoragePool> select(DiskProfile dskCh,
VirtualMachineProfile vmPr
}
}
- s_logger.debug(String.format("ClusterScopeStoragePoolAllocator is
returning [%s] suitable storage pools [%s].", suitablePools.size(),
suitablePools));
+ logEndOfSearch(suitablePools);
Review Comment:
I know it. I just think it is unnecessary. it will not bring any benefit I
think.
on the contrary, if I get log "ClusterScopeStoragePoolAllocator is returning
xxx" and grep in source code, the result will be empty.
ps: this does not mean -1 to this pr.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
