DaanHoogland commented on code in PR #6860:
URL: https://github.com/apache/cloudstack/pull/6860#discussion_r1010527012
##########
api/src/main/java/com/cloud/network/lb/LoadBalancingRulesService.java:
##########
@@ -70,7 +70,7 @@ LoadBalancer createPublicLoadBalancerRule(String xId, String
name, String descri
* the command specifying the stickiness method name, params
(name,value pairs), policy name and
* description.
* @return the newly created stickiness policy if successful, null
otherwise
- * @thows NetworkRuleConflictException
+ * @throws NetworkRuleConflictException
Review Comment:
this one is really funny
##########
server/src/main/java/com/cloud/configuration/Config.java:
##########
@@ -228,7 +228,7 @@ public enum Config {
String.class,
"network.loadbalancer.haproxy.stats.visibility",
"global",
- "Load Balancer(haproxy) stats visibilty, the value can be one of
the following six parameters :
global,guest-network,link-local,disabled,all,default",
+ "Load Balancer(haproxy) stats visibility, the value can be one of
the following six parameters :
global,guest-network,link-local,disabled,all,default",
Review Comment:
these as well won´t be updated in the db on existing installations
##########
server/src/main/java/com/cloud/configuration/Config.java:
##########
@@ -1696,7 +1696,7 @@ public enum Config {
String.class,
"baremetal.ipmi.lan.interface",
"default",
- "option specified in -I option of impitool. candidates are:
open/bmc/lipmi/lan/lanplus/free/imb, see ipmitool man page for details. default
valule 'default' means using default option of ipmitool",
+ "option specified in -I option of impitool. candidates are:
open/bmc/lipmi/lan/lanplus/free/imb, see ipmitool man page for details. default
value 'default' means using default option of ipmitool",
Review Comment:
and this (db will remain the same)
##########
plugins/user-authenticators/ldap/src/main/java/org/apache/cloudstack/ldap/LdapConfiguration.java:
##########
@@ -65,7 +65,7 @@ public class LdapConfiguration implements Configurable{
String.class,
"ldap.user.memberof.attribute",
"memberof",
- "the reverse membership attibute for group members",
+ "the reverse membership attribute for group members",
Review Comment:
this one will not update on existing installations and should (very
striuctly speaking) have an update statement in the schema upgrade file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
