stephankruggg commented on code in PR #6860:
URL: https://github.com/apache/cloudstack/pull/6860#discussion_r1012436077
##########
plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/ROOT.virtualization.v2.Msvm_VirtualSystemMigrationSettingData.cs:
##########
@@ -410,7 +410,7 @@ public class VirtualSystemMigrationSettingData :
System.ComponentModel.Component
[Browsable(true)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
[Description("For storage migration, this could be set to TRUE or
FALSE\nto determine wheither, " +
Review Comment:
```suggestion
[Description("For storage migration, this could be set to TRUE or
FALSE\nto determine whether, " +
```
##########
server/src/main/java/com/cloud/configuration/Config.java:
##########
@@ -228,7 +228,7 @@ public enum Config {
String.class,
"network.loadbalancer.haproxy.stats.visibility",
"global",
- "Load Balancer(haproxy) stats visibilty, the value can be one of
the following six parameters :
global,guest-network,link-local,disabled,all,default",
+ "Load Balancer(haproxy) stats visibility, the value can be one of
the following six parameters :
global,guest-network,link-local,disabled,all,default",
Review Comment:
```suggestion
"Load Balancer (haproxy) stats visibility, the value can be one
of the following six parameters : global, guest-network, link-local, disabled,
all, default",
```
##########
plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/ROOT.virtualization.v2.Msvm_VirtualSystemMigrationSettingData.cs:
##########
@@ -410,7 +410,7 @@ public class VirtualSystemMigrationSettingData :
System.ComponentModel.Component
[Browsable(true)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
[Description("For storage migration, this could be set to TRUE or
FALSE\nto determine wheither, " +
- "at the end of a storage migration, when the\nsource host is
beeing clean up, the " +
+ "at the end of a storage migration, when the\nsource host is being
clean up, the " +
"read only VHDs should be removedor not.")]
Review Comment:
```suggestion
"read only VHDs should be removed or not.")]
```
##########
test/integration/component/test_haproxy.py:
##########
@@ -815,7 +815,7 @@ def test_10_create_policy_enable_disable_vpn(self):
# 1. create an account
# 2. using that account,create an instances
# 3. select the Source NAT IP and configure the stikiness policy
- # 4. enable /disable the VPN. It should not impact the ceated rules
+ # 4. enable /disable the VPN. It should not impact the created rules
Review Comment:
```suggestion
# 4. enable/disable the VPN. It should not impact the created rules
```
##########
systemvm/debian/opt/cloud/bin/loadbalancer.sh:
##########
@@ -144,7 +144,7 @@ fw_entry() {
local lb_vif_list=$(get_lb_vif_list)
for vif in $lb_vif_list; do
-#TODO : The below delete will be used only when we upgrade the from older
verion to the newer one , the below delete become obsolute in the future.
+#TODO : The below delete will be used only when we upgrade the from older
version to the newer one , the below delete become obsolute in the future.
Review Comment:
```suggestion
#TODO: The below delete will only be used when we upgrade from the older
version to the newer one, the below delete will become obsolute in the future.
```
##########
test/integration/component/test_haproxy.py:
##########
@@ -815,7 +815,7 @@ def test_10_create_policy_enable_disable_vpn(self):
# 1. create an account
# 2. using that account,create an instances
# 3. select the Source NAT IP and configure the stikiness policy
- # 4. enable /disable the VPN. It should not impact the ceated rules
+ # 4. enable /disable the VPN. It should not impact the created rules
# listLBStickinessPolicies Api should show created stikiness policy
Review Comment:
```suggestion
# listLBStickinessPolicies Api should show created stickiness
policy
```
##########
CHANGES.md:
##########
@@ -682,7 +682,7 @@ Bug Fixes:
* CLOUDSTACK-1600 Typo in dpkg-buildpackage command
* CLOUDSTACK-1574 updateResourceCount API is failed saying to specify valida
resource type even after parsing the valid resource type
-* CLOUDSTACK-1562 Replace the short-cut solution of supportting @DB with the
formal one
+* CLOUDSTACK-1562 Replace the short-cut solution of supporting @DB with the
formal one
Review Comment:
```suggestion
* CLOUDSTACK-1562 Replace the shortcut solution of supporting @DB with the
formal one
```
##########
test/integration/component/test_haproxy.py:
##########
@@ -815,7 +815,7 @@ def test_10_create_policy_enable_disable_vpn(self):
# 1. create an account
# 2. using that account,create an instances
Review Comment:
```suggestion
# 2. using that account, create an instance
```
##########
systemvm/debian/opt/cloud/bin/loadbalancer.sh:
##########
@@ -161,7 +161,7 @@ fw_entry() {
sudo iptables -A lb_stats -s $cidrs -p tcp -m state --state NEW -d $pubIp
--dport $dport -j ACCEPT
-#TODO : The below delete in the for-loop will be used only when we upgrade
the from older verion to the newer one , the below delete become obsolute in
the future.
+#TODO : The below delete in the for-loop will be used only when we upgrade
the from older version to the newer one , the below delete become obsolute in
the future.
Review Comment:
```suggestion
#TODO: The below delete in the for-loop will only be used when we upgrade
from the older version to the newer one, the below delete will become obsolute
in the future.
```
##########
test/integration/component/maint/test_redundant_router.py:
##########
@@ -1641,7 +1641,7 @@ def test_06_updateVRs_in_sequence(self):
if retry == 0:
break
time.sleep(self.testdata["sleep"])
- self.info("wating for backup router to become primary router
name:"+new_backup_router.name)
+ self.info("waiting for backup router to become primary router
name:"+new_backup_router.name)
Review Comment:
```suggestion
self.info("waiting for backup router to become primary router
name: "+new_backup_router.name)
```
##########
test/integration/component/test_haproxy.py:
##########
@@ -850,7 +850,7 @@ def test_10_create_policy_enable_disable_vpn(self):
@attr(tags=["advanced", "advancedns"], required_hardware="false")
def test_11_invalid_params(self):
- """Test verfify functionality syncronous and asyncronous validations"""
+ """Test verify functionality syncronous and asyncronous validations"""
Review Comment:
```suggestion
"""Test verify functionality synchronous and asynchronous
validations"""
```
##########
server/src/main/java/com/cloud/configuration/Config.java:
##########
@@ -1696,7 +1696,7 @@ public enum Config {
String.class,
"baremetal.ipmi.lan.interface",
"default",
- "option specified in -I option of impitool. candidates are:
open/bmc/lipmi/lan/lanplus/free/imb, see ipmitool man page for details. default
valule 'default' means using default option of ipmitool",
+ "option specified in -I option of impitool. candidates are:
open/bmc/lipmi/lan/lanplus/free/imb, see ipmitool man page for details. default
value 'default' means using default option of ipmitool",
Review Comment:
```suggestion
"option specified in -I option of impitool. Candidates are:
open/bmc/lipmi/lan/lanplus/free/imb, see ipmitool man page for details. Default
value 'default' means using default option of ipmitool",
```
##########
plugins/hypervisors/hyperv/DotNet/ServerResource/WmiWrappers/ROOT.virtualization.v2.Msvm_VirtualSystemMigrationSettingData.cs:
##########
@@ -410,7 +410,7 @@ public class VirtualSystemMigrationSettingData :
System.ComponentModel.Component
[Browsable(true)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
[Description("For storage migration, this could be set to TRUE or
FALSE\nto determine wheither, " +
- "at the end of a storage migration, when the\nsource host is
beeing clean up, the " +
+ "at the end of a storage migration, when the\nsource host is being
clean up, the " +
Review Comment:
```suggestion
"at the end of a storage migration, when the\nsource host is
being cleaned up, the " +
```
##########
test/integration/component/test_haproxy.py:
##########
@@ -815,7 +815,7 @@ def test_10_create_policy_enable_disable_vpn(self):
# 1. create an account
# 2. using that account,create an instances
# 3. select the Source NAT IP and configure the stikiness policy
Review Comment:
```suggestion
# 3. select the Source NAT IP and configure the stickiness policy
```
##########
test/integration/component/test_haproxy.py:
##########
@@ -850,7 +850,7 @@ def test_10_create_policy_enable_disable_vpn(self):
@attr(tags=["advanced", "advancedns"], required_hardware="false")
def test_11_invalid_params(self):
- """Test verfify functionality syncronous and asyncronous validations"""
+ """Test verify functionality syncronous and asyncronous validations"""
# Validate the following
# verify the validation while creating or attaching stikiness policy
Review Comment:
```suggestion
# verify the validation while creating or attaching stickiness policy
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
