JoaoJandre commented on PR #6868: URL: https://github.com/apache/cloudstack/pull/6868#issuecomment-1310167126
> DATADISK and ROOT disks are different. When you destroy a vm, DATADISK will be detached from the VM, but ROOT disk will not. The VM can be recovered, no matter what the state of DATADISK is, because DATADISK is not attached. @weizhouapache default behavior is that the datadisk is not detached. Datadisks will only be detached if you pass the Datadisk id to the destroyVIrtualMachine API, then they will be detached and destroyed. > I prefer to make changes with minimum impact. If you want to change the calculation of resource count, add a global config in ResourceLimitService, and use it in ResourceLimitManagerImpl. Your solution is almost the same as mine, but without changing the root volume's state, which could make thinks confusing for users, because not counting a volume which is in ready state is almost an inconsistency. What do you think @DaanHoogland ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cloudstack.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
