Updated Branches:
  refs/heads/master d79135f4e -> eb798d319

Some StringBuffers replaced by StringBuilders

StringBuffers replaced by StringBuilders to avoid unnecesary synchronization 
overhead.

Signed-off-by: Laszlo Hornyak <[email protected]>


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/847274f3
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/847274f3
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/847274f3

Branch: refs/heads/master
Commit: 847274f31f0f1485add0beb401912e0f122618ad
Parents: d79135f
Author: Laszlo Hornyak <[email protected]>
Authored: Wed Oct 16 05:05:57 2013 +0200
Committer: Laszlo Hornyak <[email protected]>
Committed: Tue Oct 22 23:35:08 2013 +0200

----------------------------------------------------------------------
 .../cloudstack/api/command/user/network/UpdateNetworkCmd.java  | 4 +---
 .../cloudstack/api/command/user/volume/UpdateVolumeCmd.java    | 6 +++---
 api/src/org/apache/cloudstack/context/CallContext.java         | 2 +-
 3 files changed, 5 insertions(+), 7 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/847274f3/api/src/org/apache/cloudstack/api/command/user/network/UpdateNetworkCmd.java
----------------------------------------------------------------------
diff --git 
a/api/src/org/apache/cloudstack/api/command/user/network/UpdateNetworkCmd.java 
b/api/src/org/apache/cloudstack/api/command/user/network/UpdateNetworkCmd.java
index e0cd713..a44b768 100644
--- 
a/api/src/org/apache/cloudstack/api/command/user/network/UpdateNetworkCmd.java
+++ 
b/api/src/org/apache/cloudstack/api/command/user/network/UpdateNetworkCmd.java
@@ -153,9 +153,7 @@ public class UpdateNetworkCmd extends BaseAsyncCmd {
 
     @Override
     public String getEventDescription() {
-        
-        
-        StringBuffer eventMsg = new StringBuffer("Updating network: " + 
getId());
+        StringBuilder eventMsg = new StringBuilder("Updating network: " + 
getId());
         if (getNetworkOfferingId() != null) {
             Network network = _networkService.getNetwork(getId());
             if (network == null) {

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/847274f3/api/src/org/apache/cloudstack/api/command/user/volume/UpdateVolumeCmd.java
----------------------------------------------------------------------
diff --git 
a/api/src/org/apache/cloudstack/api/command/user/volume/UpdateVolumeCmd.java 
b/api/src/org/apache/cloudstack/api/command/user/volume/UpdateVolumeCmd.java
index b247e0f..d4e3a6c 100644
--- a/api/src/org/apache/cloudstack/api/command/user/volume/UpdateVolumeCmd.java
+++ b/api/src/org/apache/cloudstack/api/command/user/volume/UpdateVolumeCmd.java
@@ -114,8 +114,8 @@ public class UpdateVolumeCmd extends BaseAsyncCmd {
 
     @Override
     public String getEventDescription() {
-        StringBuffer desc = new StringBuffer();
-        desc.append(" with");
+        StringBuilder desc = new StringBuilder("Updating volume: ");
+        desc.append(getId()).append(" with");
         if (getPath() != null) {
             desc.append(" path " + getPath());            
         }
@@ -126,7 +126,7 @@ public class UpdateVolumeCmd extends BaseAsyncCmd {
         if (getState() != null) {
             desc.append(", state " + getState());
         }
-        return "Updating volume: " + getId() + desc.toString();
+        return desc.toString();
     }
 
     @Override

http://git-wip-us.apache.org/repos/asf/cloudstack/blob/847274f3/api/src/org/apache/cloudstack/context/CallContext.java
----------------------------------------------------------------------
diff --git a/api/src/org/apache/cloudstack/context/CallContext.java 
b/api/src/org/apache/cloudstack/context/CallContext.java
index a9867d3..2ee0130 100644
--- a/api/src/org/apache/cloudstack/context/CallContext.java
+++ b/api/src/org/apache/cloudstack/context/CallContext.java
@@ -265,7 +265,7 @@ public class CallContext {
 
     @Override
     public String toString() {
-        return new StringBuffer("CCtxt[acct=").append(account.getId())
+        return new StringBuilder("CCtxt[acct=").append(account.getId())
                 .append("; user=").append(user.getId())
                 .append("; id=").append(contextId)
                 .append("]").toString();

Reply via email to