weizhouapache commented on code in PR #6282:
URL: https://github.com/apache/cloudstack/pull/6282#discussion_r1071520403
##########
engine/schema/src/main/java/com/cloud/vm/NicVO.java:
##########
@@ -394,4 +397,14 @@ public String getNsxLogicalSwitchPortUuid() {
public void setNsxLogicalSwitchPortUuid(String nsxLogicalSwitchPortUuid) {
this.nsxLogicalSwitchPortUuid = nsxLogicalSwitchPortUuid;
}
+
Review Comment:
I totally agree with what @harikrishna-patnala said.
this is a very large project with many features.
if there are two good options to fix a bug, it would be better to choose the
one with less scope and impact.
If you will test all related features with different setup (hypervisors,
network types and elements,etc), then go ahead with your solution, I am fine
with it.
cc @SadiJr @JoaoJandre @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
