weizhouapache commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1072572879
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
private long _timeout = 60000; /* 1 minutes */
protected static String s_heartBeatPath;
protected long _heartBeatUpdateTimeout = 60000;
- protected long _heartBeatUpdateFreq = 60000;
+ protected long _heartBeatUpdateFreq =
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);
Review Comment:
> (1) The focus of this PR is only the `heartBeatUpdateFreq`. What other
variables would you consider necessary to externalize? (2) Yes, this will be
fixed.
@stephankruggg
good.
can you discuss with your team if other fixed values need be configurable as
well ?
if you want only this configurable, it is ok.
if you want more to be configurable, you can make all the changes in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
