GutoVeronezi commented on code in PR #6892:
URL: https://github.com/apache/cloudstack/pull/6892#discussion_r1073451284
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/KVMHABase.java:
##########
@@ -33,7 +35,7 @@ public class KVMHABase {
private long _timeout = 60000; /* 1 minutes */
protected static String s_heartBeatPath;
protected long _heartBeatUpdateTimeout = 60000;
- protected long _heartBeatUpdateFreq = 60000;
+ protected long _heartBeatUpdateFreq =
AgentPropertiesFileHandler.getPropertyValue(AgentProperties.KVM_HEARTBEAT_UPDATE_FREQUENCY);
Review Comment:
@weizhouapache, speaking as a member of the SC Clouds team, every PR opened
by someone from SC Clouds already attends to the use case the company faced. In
this case, externalizing the property `kvm.heartbeat.update.frequency` already
attends the SC Clouds use case. Therefore, if there are improvements to be done
or other cases to be considered within the proposal's boundaries, the community
should point them out; otherwise, if the community thinks it is ok as it is,
then there is nothing else to address.
Now, speaking as a member of the community, once a PR is opened, it does not
matter from which company the contributor who opened the PR is; it is a
contribution from someone to the community and should be treated as so. The
bond is not the company with the community, is the contributor with the
community; the contributor's team is the community. Then, when @stephankruggg
asked you `what other variables would you consider necessary to externalize` he
was already discussing with the team (the community) if other variables should
be externalized. Also, we have to remember that not all contributions are based
on a company's motivation; contributors want the best for the project and may
contribute to the community's evolution independently of a company saying them
to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
